Add the ability to remove usernames in the personal opening search history. #13518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to test out the local fix on my physical smartphone. Fortunately, I can reliably pick between pressing the remove button and the button to select the player. |
|
I should probably add an RTL screenshot, too: |
* master: (400 commits) use nginx whitelist in all ipTrust ratelimiters tweak ip ratelimiters fix typo fix game search perf selector - closes lichess-org#13701 Use import instead of pattern matching Study action: fix no select on Safari migrate tournament.spotlight.description remove tournament Spotlight.description object literal kick from swiss along with team Add moretime pref single field update display global errors on create/edit tournament manager page Use value instead of id for consistency Fix donation issue on /patron/list Code tweaks Adjust onPatronGift wording Fix tests Fix type errors for the rest of lila slack is dead, long live zulip Bump actions/checkout from 3 to 4 ...
|
Slight bug: when you delete the currently selected user it remains selected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12869; closes #12885; closes #13373.
This adds the ability to remove players from the personal search history.
This fix uses
gapinstead ofcolumn-gapforflexelements, as requested in #13373. Moreover, a SCSS variable collapses 3 of the 5 numerical positioning/size-related variables in the.removeclass into 1.