Fix YouTube iframe for the Racing Kings variant page #13528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix makes the iframe replacement regex more robust.
The problem lies on the Racing Kings variant page: the embedded YouTube player doesn't work.
This happens because the Racing Kings iframe ends in
allowfullscreen="" title="Racing Kings variant - Blitz Chess w/ commentary"></iframe>, which means that it is not picked up by the regex in ddc248d, which is supposed to detect theiframetag and add thecredentiallessattribute. As a result, that attribute was not added to the YouTubeiframetag for the Racing Kings page.Tests have been added for this extra case as well.