Skip to content

Conversation

@awestm
Copy link
Contributor

@awestm awestm commented Sep 25, 2023

This change fixes #13545, which specifically affects 3d pieces, although the proposed change will affect 2d pieces as well.

Before the fix:

3D
Bad3D
2D
Bad2D

After the fix:

3D
Good3D
2D
Good2D

Tested on the following platforms:

Platform Chrome 116.0.5845.187 Safari 18615.3.12.11.2 Firefox 117.0.1
Verified ✔️ ✔️ ✔️

Should be a pretty simple fix, let me know if more testing is required. This is my first issue so I could be missing something.

@kraktus kraktus changed the title Incorrect mouse hit area on promotion correct the mouse hit area on promotion Sep 26, 2023
@jruales
Copy link

jruales commented Sep 26, 2023

@awestm the previews above seem to be broken for me:
image
The file downloads work but it would be nice to be able to watch the videos in this PR itself without having to download

@awestm
Copy link
Contributor Author

awestm commented Sep 26, 2023

@awestm the previews above seem to be broken for me:
image
The file downloads work but it would be nice to be able to watch the videos in this PR itself without having to download

Hey @jruales I changed the file format to gif. Should be viewable on all browsers now.

@ornicar ornicar merged commit 6193078 into lichess-org:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect mouse hit area for promotion selection when using 3D pieces

3 participants