bugfix for Learn:Board setup 6 to not get stuck #13610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to castling lessons
|
As reported, looks like this might have broken Castling exercise 8 and 9.
|
|
Sorry about that.
PR up that fixes the lessons #13615
…On Tue, Sep 19, 2023 at 10:52 AM TBest ***@***.***> wrote:
As reported, looks like this might have broken Castling exercise 8 and 9.
https://lichess.org/forum/lichess-feedback/castling-exercise-8-and-9
—
Reply to this email directly, view it on GitHub
<#13610 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYVVSHKGHEFOSJ5YOZGMDX3FMMRANCNFSM6AAAAAA44YNDTY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix for Learn:Board setup 6 to not get stuck and minor improvemens to castling lessons.
This attempts to solve: #13581
I believe fully solving the stuck issues with the castling excersises will require patching chess.js
https://github.com/jhlywa/chess.js/releases/tag/v0.10.2
Probably worth looking into upgrading to a more recent release first as v0.13.4 seems to be latest.
https://github.com/jhlywa/chess.js/releases/tag/v0.13.4
If no one is attempting this I could look into it.