-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix missing translation on FAQ & Simul page #13888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smaller PRs that only change things in one area are preferred, but this is ok.
|
If so, can I create another pull request? I'm afraid this pull request will have conflicts. |
|
Why don't you just add commits to this one? |
|
@M-DinhHoangViet Can you create a development site using the steps below to test your changes? Here is a quick overview video first: https://www.youtube.com/watch?v=imuo-d5vGS8 To specifically work on translations, you can do these steps: Start the workspace
Add a translation
- a(href := routes.Auth.signup, cls := "action button text")("Sign up to host or join a simul")
+ a(href := routes.Auth.signup, cls := "action button text")(trans.signUpToHostOrJoinASimul())
<string name="signUpToHostOrJoinASimul">[using translated value]</string>
docker compose run --rm ui bash -c "/lila/bin/trans-dump"
docker compose restart lila
echo $(gp url 8080)/simulYou should see this in the button to verify that it worked: Repeat those steps for each of the strings you want to translate. |
|
I understand, thanks @fitztrev. But my problem is that the translations should be minimized in one go |
|
Yes, do those steps but only edit 1 of the scala files. In this example, only edit Then submit that as its own pull request. Wait for it to get approved, then move onto another file. |
| ), | ||
| h3("Google Chrome (", desktop(), "):"), | ||
| p( | ||
| browsersGoogleChrome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this line is wrong, do my changes match what you mean @ornicar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| browsersGoogleChrome | |
| browsersGoogleChrome() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked in Gitpod and maybe it was because I looked when it hadn't finished rebooting. I will reconsider |
docker compose run --rm ui bash -c "/lila/bin/trans-dump"docker compose restart lilacd /workspace/lila-docker./lila-docker format