fix wiki api failure if extract is empty but still present #13893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
added a commit
to kraktus/lila
that referenced
this pull request
Nov 1, 2023
* master: fix ui/analyse study code duplication fix wiki api failure if extract is empty but still present (lichess-org#13893) make copy buttons work add copy buttons and make all autoselect Login from public IPs: Actually check if the user has 2fa enabled index all posts, refactor scalafmt Remove topic if first and only post is deleted
ornicar
added a commit
that referenced
this pull request
Nov 1, 2023
* master: let tournaments from standard position be rated complete renaming to thematicPosition fix ui/analyse study code duplication fix wiki api failure if extract is empty but still present (#13893) make copy buttons work add copy buttons and make all autoselect Login from public IPs: Actually check if the user has 2fa enabled index all posts, refactor Scala tweak Refactor SeverEval.Merger `balancedPosition` -> `thematicPosition` Allow thematic tournaments to be rated, if position is balanced Remove topic if first and only post is deleted
kraktus
added a commit
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13877
If the extract given by Wikibooks is an empty string, but is still there, it currently throws that api error due to
lila/ui/analyse/src/wiki.ts
Lines 61 to 62 in a2f76a9
Need to check that it is not empty first, so that it doesn't show an api error in this case
I chose to just show nothing as if the opening doesn't exist (because it doesn't in Wikibooks)