Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Nov 1, 2023

closes #13885

@kraktus
Copy link
Member

kraktus commented Nov 1, 2023

Thanks! It's always nice when fixing a visual bug to include a screenshot

@ornicar
Copy link
Collaborator

ornicar commented Nov 1, 2023

It works, but... why is there a border there in the first place? I'm always uncomfortable with bugfixes I don't understand.
And why separating instead of sharing borders would prevent it from being shown?

@ghost
Copy link
Author

ghost commented Nov 1, 2023

The point of the transparent border is to allow the green and red highlights on the left when hovering:
image

You can get alignment issues in tables with border-collapse where he green border takes up more space than the rest of the tr so it tries to align it by adding a border around the next element.
image

But with separate borders this compensation is not needed
image

@ornicar ornicar merged commit deaf7ef into lichess-org:master Nov 6, 2023
@ghost ghost deleted the fix-tournament-pairing-border branch November 8, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust styling in player's tournament games list

2 participants