Skip to content

Conversation

@M-DinhHoangViet
Copy link
Contributor

@M-DinhHoangViet M-DinhHoangViet commented Nov 9, 2023

Before:
image
After:
image

@ornicar
Copy link
Collaborator

ornicar commented Nov 10, 2023

I don't see what the misunderstanding was, and why this is better?

@M-DinhHoangViet
Copy link
Contributor Author

Misunderstandings exist in the translations of some languages. Example is Vietnamese: https://crowdin.com/translate/lichess/all/en-vi?filter=basic&value=0#

@lenguyenthanh
Copy link
Member

In some language, like vietnamese, draws and draw rate are quite different. Like in the screen shot below, we should have Hoà as Tỉ lệ hoà to be consistent with the the other translates (tỉ lệ thắng and tỉ lệ thua).

Screenshot 2023-11-12 at 19 14 42

So, I think splitting draws into draws and drawRate is an improvement. But, we should reuse the English (as it is already good) and other translation (as we don't know them).

@ornicar ornicar merged commit 0cfd60f into lichess-org:master Nov 23, 2023
@M-DinhHoangViet M-DinhHoangViet deleted the patch-12 branch November 23, 2023 10:24
ornicar pushed a commit that referenced this pull request Dec 1, 2023
* Shortcoming

* Returns the correct module name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants