Add berserk icons to arena results list. Closes #13731 #13984
Conversation
|
Hello, this seems to completely hide the username of the opponent which is probably more a important information than the berserk status? |
|
I don't think so. In that screenshot, the full name of the user is Li. Here's another screenshot, this time of the whole page, and from a different sample user. |
I see thanks for the clarification 👍 UI-wise I think the column for berserk should be much narrower, like the results |
|
Ok. Will change that now. Thanks for the suggestion |
|
I can't entirely tell if this is any better. Thoughts @kraktus |
|
I think that it still is too wide, but I'm having a bit of trouble with the css currently. Will post some screenshots in a minute |
|
Generated html: |
This comment was marked as outdated.
This comment was marked as outdated.
This looking ok? |
|
Generated some screenshots with some real usernames to see what it would look like.
Then I was curious about removing the
|
* master: (66 commits) fix import analysis user moves into study improve names (no functional changes) upgrade pgn-viewer to fix empty players fix Setup controller fix Setup controller let lichobile make open challenges - closes lichess-org#13980 allow deletion of external engine from gear menu Revert "LIFAT_DIR same as nginx config" LIFAT_DIR same as nginx config restrict engine settings for practice document surprising use of Function.length configure ceval in PracticeCtrl lockfile engine hot reloads Fix solving retro mistake when browsed away No animations for insights fix antichess acpl chart Fix acpl fill color when using transp. backgrounds Closes lichess-org#13976 Bump Scalachess 15.6.11 Don't animate the graph on acquiring analysis Closes lichess-org#13970 ...
|
I also prefer |
Uses $c-font-dim to display beserk status now instead of $c-accent. Fixed bug where player beserk status was shown inseas of opponent
Changed |
This reverts commit 631523e. I am not 100% sure if it was actuallt required, so reverting it.
* master: New Crowdin updates (lichess-org#13974) Update ui/site/css/ublog/_post.scss Fix issue lichess-org#14000: Correct blog like button cut-off on Safari Lower NNUE request body minimum from 1MB to 128KB Fix inaccurate Fairy Stockfish version
…sfan/lila into berserk-in-arena-results * 'berserk-in-arena-results' of https://github.com/jenningsfan/lila: remove unnecessary string concatenation Fix change desicion to concat 2 string literals when not necesarry Revert "Change to Option[Boolean]" Change to Option[Boolean] Use $c-font-dim and fixed bug with beserk on front-end
* master: acpl chart: fix when node.eval.cp == 0 acpl chart: fix display of partial analysis acpl chart: extract value from loop Light theme bar color is blue. Closes lichess-org#13994 Change font to default lichess font Don't show datalabels for 0 values in stacked graphs Display minBarLength for 0 values in non-stacked graphs ratingDistribution tweaks. Put annotation text above the graph - closes lichess-org#13978 Don't plot supergm ratings as annotations. Add a line at y=0. Some refactoring as well Closes lichess-org#13985 Delete tooltip formatting hacks for annotations No need to display them in the tooltip anymore since we use the datalabels plugin Don't show datalabel for the bottom anchor Hide our horrible hacks Tweak x axis max and min Make it easier to select starting and ending ply. Fix Move series fill color - closes lichess-org#13986
Closes #13731, adding icons for player and opponent if they have berserked.
EDIT: screenshot of current UI iteration with real data. Thanks to @fitztrev for this screenshot
