show correct ratings in simul #13909
Conversation
| .ifTrue(simul.nbAccepted < Game.maxPlayingRealtime) | ||
| .so: variant => | ||
| val perfType = PerfType(variant, chess.Speed.Rapid) | ||
| val perfType = PerfType(variant, chess.Speed(simul.clock.config.some)) |
There was a problem hiding this comment.
2 issues with this.
- it doesn't take into account the simul variant (neither does the current code, so the problem is already here)
- most simuls use classical clock, and most players don't have a classical rating. I reckon we should try using the simul speed, and if the user has no such rating, fallback to the next faster speed (so classical->rapid)
There was a problem hiding this comment.
I did notice the first issue when looking at this and had a short discussion about it in the Discord.
I'll make more changes after tomorrow trying to fix these issues
There was a problem hiding this comment.
Thinking more about this now. It actually does take into account the simul variant! So no problems there.
Regarding second issue, I'm not sure your suggested behaviour would be best.
-
I think it would be strange to have some players showing their classical rating while some showing their blitz rating. If a player has a provisional classical rating, then this provisional rating should be shown. Blitz ratings and classical ratings are usually very different, so I do not think they are interchangeable.
-
If a simul host wants to ensure all players do have a classical rating, they can already do this. There is an entry condition to specify the minimum rating allowed. Perhaps another entry condition option to ensure the player's rating is not provisional would be good though.
-
There would be a mismatch between the rating showed on the simul page and the rating shown when you click into each game. I think this would create more confusion than it saves by just showing that the player only has a provisional classical rating.
-
If a player has no classical rating and you want to see what rating they are in rapid or blitz, you can already hover over their name to see this. For the above reasons, I do not think their rapid rating should be pretended to be their classical rating.
|
Now also shows host's variant rating, including if provisional or not. |
* master: (28 commits) Lpv scala code golf New Crowdin updates (#13911) move to ctx.canPalantir ctx.kid: KidMode use ctx.kid in Account.info scalachess 15.6.9 MsgSearch needs to know if the current request is in kid mode read canPalantir from ctx, not from user allow forcing kid mode with http header (#13882) update MarkdownTest scalafmt distinguish links to private studies do not allow embedding private studies better study permission checks in controller ignore lichess inbox "del" flag scala tweaks prevent duplicate team pmAll eject tournament players no longer on allowList - closes #13907 tournament scala tweaks nag titled players about 2FA ...
Currently, all simuls show players' rapid rating. (i.e. a blitz simul shows rapid ratings).
This fixes that so it shows the rating that corresponds to the simul's time control. (i.e. a blitz simul shows blitz ratings).
https://discord.com/channels/280713822073913354/352976626558042122/1169767913234894858