Skip to content

Add dynamicImport as an engine require #14053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2023
Merged

Add dynamicImport as an engine require #14053

merged 2 commits into from
Nov 20, 2023

Conversation

@davidrapoport
Copy link
Contributor

@davidrapoport davidrapoport commented Nov 20, 2023 •
edited
Loading

  • Make the engine requires an array to support this change.
  • Removes dynamicImport as a feature for any user on firefox < 114.
  • Adds dynamicImport as a require for SF16 engines.

Fixes #14029

@davidrapoport
Add dynamicImport as an engine require
7d1af51 
* Make the engine requires an array to support this change.
* Removes dynamicImport as a feature for any user on
firefox < 114.
* Adds dynamicImport as a require for SF16 engines.
@davidrapoport
Copy link
Contributor Author

davidrapoport commented Nov 20, 2023

@brollin hi

@ornicar ornicar requested a review from schlawg November 20, 2023 07:15
schlawg
schlawg reviewed Nov 20, 2023
View reviewed changes
schlawg
schlawg reviewed Nov 20, 2023
View reviewed changes
schlawg
schlawg suggested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@schlawg schlawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! just two nitpicks and we'll merge it.

@schlawg schlawg merged commit f594591 into lichess-org:master Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@schlawg schlawg schlawg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Local Engine doesn't load after a game

2 participants

@davidrapoport @schlawg