Fix issue #14000: Correct blog like button cut-off on Safari #14007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust margin for icons in to prevent cut-off on Safari browsers.
fitztrev
requested changes
Nov 15, 2023
Co-authored-by: Trevor Fitzgerald <fitztrev@users.noreply.github.com>
|
Can still reproduce the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This pull request addresses Issue #14000, where the 'like' button on blog posts was observed to be cut off when viewed on the Safari browser. The issue was caused by insufficient margin on the left of the
ublog-post__liketype icons.What Has Been Done
ublog-post__likeicons in theui/site/css/ublog/_post.scssfile.Why This Solution
The added margin provides sufficient space to render the icons properly on Safari without affecting their appearance or layout on other browsers. This solution was chosen for its simplicity and effectiveness in resolving the display issue specifically on Safari.
Testing
The changes have been tested on:
No adverse effects on the layout or functionality were observed in these tests.
Looking forward to any feedback or further suggestions for improvement. Thank you for considering this fix!