fixed #13867 tournament requirements styling #14019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a tournament is finished, the requirements should still be listed but without the styling to see if the conditions are met or not. This fixes #13867
fitztrev
reviewed
Nov 16, 2023
After a review, made the one-liner cleaner by just passing the !tour.isFinished into the `relevant` flag.
This commit removes the conditional formatting for Swiss tournament requirements in the same way it was done for regular tournaments. This is done by passing !Swiss.isFinished into the `relevant` flag when rendering the verdicts.
* master: remove superfluous account CSS classes, some scala tweaks show completed game result in blind mode fix typo prettierignore readme and add -n short arg for --no-install remove unnecessary tsc flag fix insight & chart tsc deps use pnpm again remove npm package-lock and old config file template handle package.json change Fix cli search for mobile Update scalafmt-core to 3.7.17 Update lettuce-core to 6.3.0.RELEASE fixing remove duplicated quotes css add tag id and link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a tournament is finished, the requirements should still be listed but without the styling to see if the conditions are met or not.
This fixes #13867