show blocked message not parsing > #14151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oof still breaking if no : |
|
can remove the innerText match and use only the innerHtml. thoughts? |
ornicar
reviewed
Dec 5, 2023
ui/site/src/forum.ts
Outdated
| }); | ||
| $('.forum-post__message').each(function (this: HTMLElement) { | ||
| if (this.innerText.match(/(^|\n)>/)) { | ||
| const isVisible = window.getComputedStyle(this).display !== 'none'; |
There was a problem hiding this comment.
not a fan of getComputedStyle, it's hacky and slow - and runs on each blog post. Can we test a class instead?
There was a problem hiding this comment.
i didn't know this 😮
ornicar
reviewed
Dec 5, 2023
|
Can we instead parse the blockquotes at the moment the message is displayed, when the user clicks the "show blocked message" button? |
i tried something like this after reverting my prev changes, but now there is some code duplication. i could move it to a separate function but then don't know where to put it. $('.forum-post__blocked button').on('click', e => {
const el = (e.target as HTMLElement).parentElement!;
const message = el.querySelector('.forum-post__message') as HTMLElement;
if (message.innerHTML.match(/(^|<br>)>/)) {
const hiddenQuotes = '<span class=hidden-quotes>></span>';
let result = '';
let quote = [];
for (const line of message.innerHTML.split('<br>')) {
if (line.startsWith('>')) quote.push(hiddenQuotes + line.substring(4).trim());
else {
if (quote.length > 0) {
result += `<blockquote>${quote.join('<br>')}</blockquote>`;
quote = [];
}
result += line + '<br>';
}
}
if (quote.length > 0) result += `<blockquote>${quote.join('<br>')}</blockquote>`;
message.innerHTML = result;
}
$(el).replaceWith($('.forum-post__message', el));
}); |
* master: refactor ui/lobby modals fix style of decline challenge page fix typing & usage of lichess.asset.userComplete Update list.txt add 2024 flair hide online status when challenging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14126
EDIT - https://stackoverflow.com/questions/67286355/div-innertext-loses-new-lines-after-setting-display-to-none is the reason
not sure if this is the proper fix
without blocked button
for some reason idk, when blocked button this happens, so it doesn't get matched by the regex
