remove comma from team leaders #14196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitztrev
requested changes
Dec 9, 2023
app/views/team/show.scala
Outdated
Comment on lines
77
to
81
| fragList( | ||
| t.publicLeaders.toList.map: l => | ||
| userIdLink(l.some), | ||
| " " | ||
| ) |
There was a problem hiding this comment.
I would say option B (using CSS). And if there's no separator you can just do this:
Suggested change
| fragList( | |
| t.publicLeaders.toList.map: l => | |
| userIdLink(l.some), | |
| " " | |
| ) | |
| t.publicLeaders.toList.map: l => | |
| userIdLink(l.some) |
There was a problem hiding this comment.
Probably don’t need the tolist anymore to map too
There was a problem hiding this comment.
Probably don’t need the tolist anymore to map too
oh t.publicLeaders is a List already
fitztrev
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #14089
i had used
" "instead of""i could also do something like
fragList( t.publicLeaders.toList.map: l => userIdLink(l.some), "" )and
not sure what would be best