WIP on qr code feature for #14173 #14260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I find the layout unbalanced |
|
yeah agreed it looks a bit off. I will change it to be like the diagram included in the original feature request. |
|
I think this is pretty clean. QR code is big and visible. Open to comments |
* master: (206 commits) fix /video 404 page - closes lichess-org#14262 Move classification flairs (fixes lichess-org#14264 ) (lichess-org#14265) add puzzle theme translation keys to the streak page - closes lichess-org#14273 fix ui storage must remove the birthday key on expiration rename and factor ui storage birthday key New Crowdin updates (lichess-org#14271) hard coded ttl always remove unused function persistent log ws failures switch from xz to zstd for artifacts fix deploy after artifacts v4 update update to potentially much faster upload-artifact v4 scala tweak, use form3.submit remove code duplication in ublog post ranking make it a bit clearer which fields are required when recomputing upost rank fix ublog post ranking when there is no rankAdjustDays don't confuse user with mod in mod log simplify using post.created.by tweak default broadcast pull periods recover from missing broadcast game using index.json metadata - closes lichess-org#14270 ...
|
nicely done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix uses the challenge id link which is sent to https://goqr.me/api/ to generate a qr code. Not sure if this an acceptable way to do it given it creates a dependency on an external api Lichess does not control. Local testing seems to work with no issues.