store blindfold in game db #14261
store blindfold in game db #14261
Conversation
app/views/game/mini.scala
Outdated
| dataState := s"${Fen writeBoardAndColor pov.game.situation},${pov.color.name},${~pov.game.lastMoveKeys}" | ||
| def renderState(pov: Pov)(using me: Option[Me]) = | ||
| val fen = | ||
| if me.exists(pov.player.userId.has) && pov.player.blindfold.nonEmpty || |
There was a problem hiding this comment.
if me.exists(pov.player.isUser)
There was a problem hiding this comment.
Probably not useful outside of blindfold mode, but empty board fen could be a constant in scalachess as well.
|
I'm not happy with the big changes and added complexity for this ultra-niche feature. Which by the way already exists - this is only making an ultra-niche feature somewhat better.
is not a goal as it will make people pretend to be blindfolded, while they look pieces up from another browser session. Blindfold can only be a presentation setting, and the server is not interested in knowing about it, because it will then become something people lie about. I see there are unrelated improvements in that PR, I'm interested in those. |
|
There's a few new case classes and a new game field (which will be rare), but I'm not sure how much added complexity it is in the scheme of things. If you remove the new svg icon source lines and unrelated changes, I'm pretty sure this is net negative SLOC. It replaces an extremely cumbersome display preference with a more useful and accessible control. Sure let's remove the icon, but the game field is interesting historical data that supports achievements, pgn header/annotations, mini-board display, searches, etc. We can remove voice & keyboard input from the board menu to keep it trim. But blindfold toggle still needs to be there if it's no longer a preference. I can't really tell if you've already made up your mind, but if you haven't - sleep on it |
Uh oh!
There was an error while loading. Please reload this page.