Replace Highcharts with chartjs #14357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: New Crowdin updates (lichess-org#14318) proxy without auth undo change to generated dest file scalachess 15.7.5 fix brilliant typo fix logging customize ws host from debug url Update JsonView.scala fix typos (though "brillant" may be an actual bug) bump codeql actions to v3 set puzzle issue from cli
|
I have also worked on a function to color the movetime graph on analysis hover similar to the currently present |
* master: Update ES and TR Dictionary
best would be to format it using the translated date function https://github.com/lichess-org/lila/blob/master/ui/site/src/component/timeago.ts#L42 but I couldn't figure it out
|
Excellent work, thank you! So glad to finally be rid of Highcharts - and the UI just became better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #13897. Closes #3509. Closes #11653. Removes all traces of highcharts except in the legal stuff (I leave that to someone more knowledgeable). Replaces the lag chart and the rating history chart—also some fixes for other charts.
Chartjs does not have a native time series range selector or a gauge chart so I've crudely glued together some components.
The good (mainly concerning rating-history):
The bad:
2. Time series slider is laggier on slower devices. This is not noticeable for most people with an ok system. To be fair, highcharts is also laggy with 6x slowdown but not as bad as this is. That being said, I think the improved hover performance far outweighs this. Here is a video demonstration (Edit-seems to be viewable on chrome only) with and without CPU throttling:
Sliding:
Slide.mp4
Hovering:
Hover.mp4