Do not add UTCDate, UTCTime tags to study chapter PGNDumps #14330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'd make more sense to remove those only if a |
|
Makes sense. Will update PR asap |
…Date tag does not exist already
|
I made an update so the UTCDate and UTCTime tags gets exported if the Date tag does not exist. The point about conflicting with an already existing Date tag I'm not sure how to handle or if we should? |
|
Yeah I agree simply checking for the date tag is enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve issue:
#14023
by not adding UTCDate, UTCTime tags to study chapter PGNDumps.
Related forum topic:
https://lichess.org/forum/lichess-feedback/why-games-dates-always-change-to-the-current-after-downloading-chaptersstudies?page=1