Fix rating diff being undefined when solving unrated puzzles #14403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes lichess-org#14393 The issuse was created lichess-org#14277 which itself was introduced by 4a54a23. More specifically a76f4c3 and 0649bc5. It was caused by changing to `looseH` which cannot handle a number, and which tried to re-unify 0 and null as the same value, which is not possible in this case. I rolled back to the old version. I chose to use the original `h` function, so had to revert the `looseH` alias. It's more code but felt cleaner than aliasing h. Tested for: - rated - unrated - streak
|
I merged because the fix is needed. But if we start using both vanilla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14393
The issuse was created #14277 which itself was introduced by 4a54a23. More specifically a76f4c3 and 0649bc5.
It was caused by changing to
looseHwhich cannot handle a number, and which tried to re-unify 0 and null as the same value, which is not possible in this case. I rolled back to the old version.I chose to use the original
hfunction, so had to revert thelooseHalias. It's more code but felt cleaner than aliasing h.Tested for: