Added show eval toggle on broadcast multiboard page #14540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I tried adding the translation to study.xml and ran |
I think you missed in https://github.com/lichess-org/lila/blob/master/app/views/study/jsI18n.scala |
Thanks! that worked. |
|
Ohh, I think the translation will be added using crowdin. |
|
Shall I also fix #14320 in this pr? |
* master: simplify puzzle dashboard css mobile firefox doesnt support COEP credentialless 14535 - Margin Fix for Metric Buttons
ornicar
added a commit
that referenced
this pull request
Jan 24, 2024
ornicar
added a commit
to allanjoseph98/lila
that referenced
this pull request
Jan 26, 2024
* master: (40 commits) multiboard eval tick: remove unncesseray inlined style/CSS attribute Added visual indicator for showing advantage in mini-board broadcast monitor firebase data msgs separately fix push notification recipient add source field to game json export only export reports created by the player fix typos scalachess 15.7.6 Personal export: clarify that reports concerning you only include messages you posted Acpl chart: live update and spinner for studies game analysis CSP - closes lichess-org#14536 scala tweaks allow partial pull/push of broadcast round PGN show multiboard evals even if local eval is disabled - after lichess-org#14540 New Crowdin updates (lichess-org#14517) request cloud evals when toggling the option redesign multiboard options set multiboard.showEval to true by default tweak evaluation bars wording remember multiboard.showEval value using local storage ...
ornicar
added a commit
to schlawg/lila
that referenced
this pull request
Jan 28, 2024
* master: (31 commits) game analysis CSP - closes lichess-org#14536 scala tweaks allow partial pull/push of broadcast round PGN show multiboard evals even if local eval is disabled - after lichess-org#14540 New Crowdin updates (lichess-org#14517) request cloud evals when toggling the option redesign multiboard options set multiboard.showEval to true by default tweak evaluation bars wording remember multiboard.showEval value using local storage use a toggle for multiboard showEval no need to reload multiboards, just redraw simplify puzzle dashboard css mobile firefox doesnt support COEP credentialless Removed log statement remember when bulk clock was started User.isVerifiedOrChallengeAdmin tweak bulk limits new endpoint to show a bulk export more games by ID ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added show eval toggle on broadcast multiboard page. This currently only shows eval if it is currently available. Should this toggle request eval if it is not available? Closes #14497
Also can you help me with ctrl.trans.noarg('Show Eval'), the playing above gets translated to other languages but this does not?