Skip to content

Conversation

@jadijadi
Copy link
Contributor

When on a RTL language (Arabic, Persian, ..) the Settings ~ Background ~ Image shows the grid on a misplaced location. This fixes the issue on both >650 and <650 screen sizes.

fixes #14532

@jadijadi jadijadi force-pushed the rtl-background-grid branch from 25f44ea to 440aea8 Compare January 28, 2024 11:44
@allanjoseph98
Copy link
Member

The current css for that element has right: 0; because we want the box to end on the right (assuming an ltr context).
For an rtl viewer, we'd want the box to end on the left by setting left: 0;

We can set both at the same time using the variable $end-direction. See other uses in _dasher.scss for examples.

@jadijadi
Copy link
Contributor Author

Thanks for the explanation. Will apply & test and will send another PR by tomorrow.

@jadijadi jadijadi force-pushed the rtl-background-grid branch from 440aea8 to 6c36b06 Compare January 28, 2024 13:05
@jadijadi
Copy link
Contributor Author

thanks @allanjoseph98 , looked into #{$end-direction}. Very clean and cool :) updated my PR

@ornicar ornicar merged commit 279972d into lichess-org:master Jan 30, 2024
@jadijadi jadijadi deleted the rtl-background-grid branch January 30, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Picture background dropdown menu hidden when viewing rtl

3 participants