Skip to content

Make position evaluation glyphs available via shortcuts #14661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Make position evaluation glyphs available via shortcuts #14661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5d0b42
Make position evaluation glyphs available via shortcuts
phihag Feb 11, 2024
ab42feb
Merge branch 'master' into evaluation-glyph-shortcuts
ornicar Feb 12, 2024
f28aa80
TS code golf
ornicar Feb 12, 2024
3b6de69
tweak move annotation wording
ornicar Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/views/site/help.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ object help:
row(kbd("g"), trans.study.annotateWithGlyphs()),
row(kbd("n"), trans.study.nextChapter()),
row(kbd("p"), trans.study.prevChapter()),
row(frag((1 to 6).map(kbd(_))), trans.toggleGlyphAnnotations())
row(frag((1 to 6).map(kbd(_))), trans.toggleGlyphAnnotations()),
row(frag(kbd("shift"), (1 to 8).map(kbd(_))), trans.togglePositionAnnotations())
),
header(trans.mouseTricks()),
tr(
Expand Down
1 change: 1 addition & 0 deletions modules/i18n/src/main/I18nKeys.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,7 @@ object I18nKeys:
val `toggleVariationArrows` = I18nKey("toggleVariationArrows")
val `cyclePreviousOrNextVariation` = I18nKey("cyclePreviousOrNextVariation")
val `toggleGlyphAnnotations` = I18nKey("toggleGlyphAnnotations")
val `togglePositionAnnotations` = I18nKey("togglePositionAnnotations")
val `variationArrowsInfo` = I18nKey("variationArrowsInfo")
val `playSelectedMove` = I18nKey("playSelectedMove")
val `newTournament` = I18nKey("newTournament")
Expand Down
3 changes: 2 additions & 1 deletion translation/source/site.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,8 @@
<string name="keyNextBranch">Next branch</string>
<string name="toggleVariationArrows">Toggle variation arrows</string>
<string name="cyclePreviousOrNextVariation">Cycle previous/next variation</string>
<string name="toggleGlyphAnnotations">Toggle glyph annotations</string>
<string name="toggleGlyphAnnotations">Toggle move annotations</string>
<string name="togglePositionAnnotations">Toggle position annotations</string>
<string name="variationArrowsInfo">Variation arrows let you navigate without using the move list.</string>
<string name="playSelectedMove">play selected move</string>
<string name="newTournament">New tournament</string>
Expand Down
4 changes: 4 additions & 0 deletions ui/analyse/src/keyboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,11 @@ export const bind = (ctrl: AnalyseCtrl) => {
// navigation for next and prev chapters
kbd.bind('p', ctrl.study.goToPrevChapter);
kbd.bind('n', ctrl.study.goToNextChapter);
// ! ? !! ?? !? ?!
for (let i = 1; i < 7; i++) kbd.bind(i.toString(), () => ctrl.study?.glyphForm.toggleGlyph(i));
// = ∞ ⩲ ⩱ ± ∓ +- -+
for (let i = 1; i < 9; i++)
kbd.bind(`shift+${i}`, () => ctrl.study?.glyphForm.toggleGlyph(i == 1 ? 10 : 11 + i));
}
};

Expand Down