More arena and swiss tournament translations #14624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-DinhHoangViet
commented
Feb 6, 2024
* master: (91 commits) select the broadcast games tab if there are games tweak move annotation wording TS code golf Make position evaluation glyphs available via shortcuts remove prismic url from config don't reset a broadcast board on initial fen change, if moves were played maket it possible for shusher to enter team mod view show team chat is mod is shusher but not team manager hotfix snab dialogs clobbering body overflow tweak team chat modding LCC uses chess960 position 518 for standard chess list up to 100 ongoing broadcasts picfit now handles webp remove unneeded feed package file give the feed its own module, remove blog module remove prismic dependency New Crowdin updates (lichess-org#14648) Update translation/source/broadcast.xml for consistent casing Fixed the subscibed broadcast heading and title Fixed conf/routes formatting ...
ornicar
reviewed
Feb 12, 2024
ornicar
reviewed
Feb 12, 2024
don't use .txt to render html
ornicar
reviewed
Feb 12, 2024
ornicar
reviewed
Feb 12, 2024
ornicar
reviewed
Feb 12, 2024
ornicar
reviewed
Feb 12, 2024
|
Thank for reviewed. I will review the whole thing and will confirm for you to merge tomorrow. |
|
? |
ornicar
requested changes
Feb 27, 2024
| case (_, Some(max)) if full => s"≤${max.rating} ${xArena.txt(speed.trans)}" | ||
| case (_, Some(max)) => s"≤${max.rating} ${speed.trans}" | ||
| case (_, Some(max)) if full => maxRatingXArena.txt(max.rating, speed.trans) | ||
| case (_, Some(max)) => maxRatingX.txt(max.rating, speed.trans) |
There was a problem hiding this comment.
there's literally no text to translate there. And it's only confusing to the translators: ≤ %1$s %2$s.
Just leave these 2 lines as they were.
|
I'm sorry @ornicar for sending so many commits |
* master: (68 commits) search /fide players by name and fide id /fide css fix fide player tournaments pagination guess fide ids of players of all past broadcasts proper bson reader for Chapter.RelayAndTags link to the federation page show fide player lichess broadcasts show fide player title fide player page wip fix federation players infinite scroll federation page with player list split fide views federation list page Dont send request to lila-fishnet when the game is finished Scala tweak tweak fide player caches fix broadcast board flag display on firefox New Crowdin updates (lichess-org#14763) cleanup fide player names rename relay textarea data ...
* master: make /fide visible fix deprecation warning, use .view.mapValues(f) scalafmt
ornicar
reviewed
Feb 28, 2024
translation/source/arena.xml
Outdated
| <string name="rankAvg">Rank average</string> | ||
| <string name="thisPlayerHasNotCreatedAnyTourYet">This player has not created any tournament yet.</string> | ||
| <string name="thisPlayerHasNotPlayedInAnyTourYet">This player has not played in any tournament yet.</string> | ||
| <string name="thisPlayerHasNotJoinedAnyTourYet">his player has not joined any tournament yet.</string> |
There was a problem hiding this comment.
also this one had a typo, the first letter is missing.
|
I wish you would take the time to review your own work. I'm browsing each affected page and finding so many typos and mistakes. A quick proofreading and testing should have been enough to fix most of them, before asking for someone else to review. |
I've seen at least 3 forms in this PR: "tournament", "tour", and "tourn". Pick one.
Imagine being a translator and seeing this ≤ %1$s %2$s Arena Pretty hard to figure out how to translate it correctly
This was referenced Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ornicar
Follow #14607