Allow all Lichess TV Channels to be embedded as iFrames #14726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endpoints for each channel.
…ming from; Fix embed not using channel feed url if channel is specifified
… nonexistent channel specified; add /api/tv/:chanKey/feed endpoint similar to /api/tv/feed
|
Thanks for the PR! Tested 👍 |
* master: (26 commits) allow the mobile app up to 3 concurrent data streams refactor controllers with LilaController.meOrFetch look at ip reputation for some anon requests New Crowdin updates (lichess-org#14727) dedup stockfish name in ui/ fishnet updated to sf 16.1 Update sbt to 1.9.9 hide overflow for odd coach-widgets too scala fmt hide overflow Update JSON response format for PGN push fix mod log for blog rank tweaks fix broadcast player fide guess from name+title use new pgn tag utilities clear broadcast leaderboard cache on tournament update guess broadcast player fide id from name+title, upgrade scalachess fix study multiboard when only one player name is known fix chapter fideId bson handler scala tweaks tweak broadcast title font sizes ...
because Map.apply may throw an exception, and relying on the context is not a future-proof guarantee.
and move it to lila.round
|
Very impressive work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5941
a. Moved TvBroadcast from lila.round to lila.tv
b. Created a TvBroadcast for each channel
c. Have TvBroadcast listen to TvSelect events rather than featuredGame and create feed based on this
Example of new channel feed endpoint and feed frame in action for chess960:
