fix video page breakage on small-width screens #14810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the page got to small, the tag bar becomes horizontal at the top of the screen and forces a very wide screen width. Giving the bar overflow-x allows it to shrink to the screen, allowing the other objects to align properly as well.
|
@schlawg (requested to be notified upon draft release) |
|
Excellent, looks good to me! My only request - we avoid declaring style attributes in scalatags when there's a good alternative. Unfortunately, the appropriate scss source file can be fiendishly difficult to find (it's a problem). In this case you want |
|
Theres also a little scrollbar for horizontal scroll even on desktop screen so put it inside some media query |
|
just use overflow-x: auto |
as per request, in alignment with repo style standards
…into page-menu-layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a pull request for this but didn't do it properly and I believe the build failed because of it
Fixes #14740
Before:
After: