Skip to content

Conversation

@TheVanadium
Copy link
Contributor

Fixes #14742
image

TheVanadium and others added 3 commits March 6, 2024 16:22
Titles longer than 3 lines have the third line cut off halfway
This commit replaces the cutoff with an ellipsis
@TheVanadium
Copy link
Contributor Author

I checked this in Firefox, and I use the gitpod docker it doesn't work in other browsers. If something about this code doesn't work in another browser, please let me know so I can adjust it.

@fitztrev
Copy link
Member

fitztrev commented Mar 8, 2024

the gitpod docker it doesn't work in other browsers

If you run gp ports visibility 8080:public on gitpod, you'll be able to access it from other browsers. By default, it restricts access to the same session you are logged into gitpod using. But if you make it public you can use other browsers, incognito, or share it with others.

@schlawg
Copy link
Contributor

schlawg commented Mar 8, 2024

It's an improvement. If you'd like to further track down Safari/mobile issues, feel free. But lgtm.

@schlawg schlawg merged commit 0b05e1a into lichess-org:master Mar 8, 2024
@ornicar
Copy link
Collaborator

ornicar commented Mar 9, 2024

I don't think it's an improvement

      -webkit-line-clamp: 2;
      display: -webkit-box;
      -webkit-box-orient: vertical;

We shouldn't be needing these exotic, vendor-prefixed properties. I'll be reverting the commit.

https://developer.mozilla.org/en-US/docs/Web/CSS/box-flex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video Library - long titles are cutoff from the card

4 participants