Apply player replacements also for Push PGN #14965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a broadcast,
it is possible to specify player replacements which will happen for rounds belonging to the broadcast, i.e
<player name> = <fide id>This works for rounds which uses Sync URL, i.e fetched PGN, but it doesn't apply to PGN which is being pushed.
This Pull Request applies player replacements also for pushed PGN.
Note, maybe this isn't desired... Maybe not applying replacements on pushed PGNs was a deliberate choice... 😅
scala-cli reproducer PushPgn.scala
After fix applied, White player tags are replaced: