Skip to content

Add API option to retrieve puzzle activity after a specific datetime #14988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2024
Merged

Add API option to retrieve puzzle activity after a specific datetime #14988

merged 4 commits into from
Apr 1, 2024

Conversation

@bassepeder
Copy link
Contributor

@bassepeder bassepeder commented Mar 29, 2024

Closes #14947.

lenguyenthanh
lenguyenthanh requested changes Mar 29, 2024
View reviewed changes
@lenguyenthanh
Copy link
Member

lenguyenthanh commented Mar 29, 2024 •
edited
Loading

Thanks for the PR! It looks great, I just have a small code golf suggestion.

And could you add example of before and after query?

@bassepeder
Copy link
Contributor Author

bassepeder commented Mar 29, 2024 •
edited
Loading

Thanks for the PR! It looks great, I just have a small code golf suggestion.

And could you add example of before and after query?

Sure, here is a screenshot of the API response using the new since query parameter:

Without since query parameter With since query parameter
CleanShot 2024-03-29 at 10 07 35 CleanShot 2024-03-29 at 10 08 35

@lenguyenthanh lenguyenthanh requested a review from ornicar March 31, 2024 12:54
@ornicar ornicar merged commit bcf620d into lichess-org:master Apr 1, 2024
@bassepeder bassepeder deleted the puzzle-after-date branch April 1, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenguyenthanh lenguyenthanh lenguyenthanh approved these changes

@ornicar ornicar Awaiting requested review from ornicar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API Option Request - Puzzle Activity AFTER a specified datetime

3 participants

@bassepeder @lenguyenthanh @ornicar