Set min height for Tournament winners #14922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This only fixes the tournament winners, the leaderboard div will still be missing. when rating not shown |
|
@randompearl-stack when you turn off Show player ratings it is suppose to remove the leaderboard as well as other places where rating is showed. The issue is that when the leaderboard gets removed, Tournament Winners has very low space. This code is to fix the height issue. |
|
Okay nevermind, the fix works, I thought that it would still show the leaderboard but without the players' ratings, like how the leaderboard page shows only the names of the top players. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set minimum height when only Tournament winners is getting displayed in the lobby screen. This will fix #14864 .Adding screenshots before and after code change for reference:
Before :
After :