Broadcast: Add private tier #15077
Merged
Broadcast: Add private tier #15077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tag has been implemented, but it needs a filter so it doesn't appear yet |
|
|
* master: add lila.ui to better organize templating across modules move some tutor templates to lila.tutor.ui reorder modules in build.sbt remove study dep to analyse fix insights perf db type fix puzzle service initialization order fix msg service initialization order fix puzzle service initialization order lila.tree.Analyser WIP z-index tricks only embed lpvs on auto link
and I don't think it's worth caching it either
|
looking pretty good. I still have to check that private broadcasts can't be found by other players. |
I think it can be detected on the |
unless seen by the logged in user
the two `tier` selectors were colliding
|
This is basically useless until the broadcasts studies are made private. Which means:
|
|
I think we can leave this configuration to broadcasters to decide what is best for each study |
* master: let kids read lichess blog posts - closes #15092 Revert annotator test Make GameToRoot an object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we need to offer support, to organizers without delay and we cannot be limited