migrate to pnpm 9 and node 20 #15116
Conversation
|
Thanks, looks good. As we discussed, I'm going to give pnpm 9 a bit more bake time. And we'll merge this soon. |
|
pnpm 9 is the archlinux repos, I'm ready :D |
58aa010 to
5ad6467
Compare
|
I just rebased and used the latest version of pnpm currently available ( By the way, if you don't plan on using corepack to always have the exact matching version of pnpm, maybe disabling the new default
|
|
Why do we need to enforce a precise version of pnpm? |
|
The new pnpm-lock format used here requires pnpm 9, which is why I specified ^9 in the 'engines' - but pnpm 9 itself defaults to using the exact version unless the strict setting I mentioned is disabled. I think the idea is that when using corepack, everybody will always be using the exact same version of the package manager to prevent any unexpected behavior, but this might be too strict here - hence why I mentioned to disable this new strict behavior if corepack will not be used by everybody 🙂 |
|
hmm I suppose we should all go for corepack then 🤔 |
|
We are OK with node 20 being the new baseline then? |
|
I don't see why not. It's an LTS and they're already at v22. |
* master: (29 commits) move single functions up to package root lila.racer.ui tv scala tweaks use Language type in routing type safe StudyOrder in routing - closes lichess-org#15255 Add "outlook.com.au" to email whitelist partial fix for gif exports Update sbt to 1.10.0 more router type safety background-image in %metal also conflicts with %active, so just revert it more router type safety fix forum post redirect add missing import forum router type safety arena/swiss/simul router type safety fix blue lobby buttons (and others) in transparent mode study routing types repair unfocused search & replace fix UblogPostId typing UblogPostId in routes, delete historical blog timeline events ...
This is my first attempt at contributing to Lichess, feedback is welcome 😄
What this PR changes
pnpmversion in thepackageManagerfield which is used by corepackpackageManagerpnpmv8 to v9 andnodefrom v14 to v20 (because of corepack and pnpm)pnpm-lock.yamlto the latest format without changing any version (I just ranpnpm installlocally)How to update this PR (if it was sitting stale for a while
pnpm-lock.yamlfrom the current mastercorepack use pnpm@latestpnpm-lock.yamlto latest format:pnpm installOpen tasks
If this is merged, the Lichess Development Onboarding must be updated, I recommend to use the latest LST (e.g. 20) and run
corepack enableonce so you'll always have the correct version ofpnpm, which is also described on the pnpm documentation.