Skip to content

Remove invalid and redundant styles #15454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Remove invalid and redundant styles #15454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62f3428
remove invalid and redundant styles
randompearl-stack Jun 6, 2024
3bba193
Merge branch 'master' into patch-1
ornicar Jun 8, 2024
4ed4b61
fix puzzle controls margin
ornicar Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ui/opening/css/_next.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@
piece {
opacity: 0.8;
}
cg-board {
background-color: none;
}
}
&__title {
@extend %flex-between-nowrap;
Expand Down Expand Up @@ -76,10 +73,5 @@
text-align: right;
}
}
&:hover {
&__popularity span {
background: $c-primary;
}
}
Comment on lines -79 to -83
Copy link
Contributor Author

@randompearl-stack randompearl-stack Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opening__next:hover__popularity span is supposed to be opening__next__popularity:hover span, and also the element is$c-primary without hover.

}
}
2 changes: 1 addition & 1 deletion ui/puzzle/css/_tools.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@

position: relative;
height: $col3-uniboard-controls;
margin-top: #{-$puzzle-block-gap};
Copy link
Contributor Author

@randompearl-stack randompearl-stack Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this instead of fixing it because the current placement of the puzzle controls looks fine.

margin-top: calc(0px - #{$puzzle-block-gap});

@include mq-is-col1 {
height: $col1-uniboard-controls;
Expand Down
2 changes: 0 additions & 2 deletions ui/tournament/css/schedule/_finished.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
}

td {
padding: 1em inherit;

> span,
> a > span {
display: block;
Expand Down