fixing styling issue with friends list and opponents #15560 #15562
Conversation
…ext translations as alt attributes instead of text elements
|
|
|
I think we should turn it into a button |
|
broken by #15260 |
…ng the text translations as alt attributes instead of text elements" This reverts commit 2c2b52b.
… shown via paged results
|
I updated the PR so the translated text is still added if shown on paginated results. |
| else | ||
| api.follow(me, user.id).recoverDefault >> negotiate( | ||
| renderActions(user.name, getBool("mini")), | ||
| renderActions(user.name, getBool("mini"), getBool("showText")), |
There was a problem hiding this comment.
?? Why is showText read from the HTTP request query parameters?
There was a problem hiding this comment.
In my initial fix I had not realised that when toggling e.g. follow/unfollow the text captions would re-appear as logic at runtime would not have the info if presented for paginated results or single user. Looking at the approach done for mini layout of the relation UI, I copied that approach.
Perhaps I could also attempt fixing this via introducing some additional routes?
e.g (/api/rel/follow/${user}/partial)
fixing styling issue with friends list and opponents by setting the text translations as alt attributes instead of text elements