Stop using http request to index forum posts as We use lila-search's ingestor for indexing #15517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
023f554 to
d241d66
Compare
We use lila-search's ingestor instead
d241d66 to
7ac6ae9
Compare
ornicar
reviewed
Jun 16, 2024
| .distinctEasy[ForumPostId, List]("_id", $doc("userId" -> user.id), _.sec) | ||
| .map: ids => | ||
| Bus.pub(BusForum.ErasePosts(ids)) | ||
| .map(ids => Bus.pub(BusForum.ErasePosts(ids))) |
There was a problem hiding this comment.
the entire function should be gone
There was a problem hiding this comment.
I think We don't delete user's forum posts in db. Only remove forum post's indexes in elastic search. That's why I keep this.
lenguyenthanh
commented
Jun 16, 2024
|
|
||
| def deleteTopic(view: PostView)(using Me): Funit = | ||
| for | ||
| postIds <- postRepo.idsByTopicId(view.topic.id) |
There was a problem hiding this comment.
I removed it because We didn't use postIds but this probably caused by an oversight: 5c94dc2#diff-27d0d9308aaabb53c6b0b2d6f43db2c751e7a7577ec4041e031d8d6f3338469e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go with lichess-org/lila-search#228