fix missing translations features page #15603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
reviewed
Jul 15, 2024
| tr(unlimited)( | ||
| "Play and create ", | ||
| a(href := routes.Simul.home)("simultaneous exhibitions") | ||
| a(href := routes.Tournament.home)(trans.features.playAndCreateSimul()) |
There was a problem hiding this comment.
you changed the href and made it wrong.
There was a problem hiding this comment.
this translation key is singular while the previous one is plural, fortunately they're both superfluous
the number was given as a string
ornicar
reviewed
Jul 16, 2024
translation/source/features.xml
Outdated
| <string name="ifYouLoveLichess">If you love Lichess,</string> | ||
| <string name="supportUsWithAPatronAccount">Support us with a Patron account!</string> | ||
| <string name="allFeaturesAreFreeForEverybody">all features are free for everybody, forever!</string> | ||
| <string name="weBelieveEveryChessPlayerDeservesTheBest">We believe every draughts player deserves the best, and so:</string> |
ornicar
reviewed
Jul 16, 2024
| a(cls := "button", href := routes.Plan.index)("Support us with a Patron account!") | ||
| trans.features.ifYouLoveLichess(), | ||
| a(cls := "button", href := routes.Plan.index)(trans.features.supportUsWithAPatronAccount()) | ||
| ) |
There was a problem hiding this comment.
the text of this box no longer makes sense.
|
Your pull requests take a long time to review and fix. Please try to focus more on quality and less on quantity. Your motivation should be to help the project rather than feeding your fancy github profile. So please take the time to proof-read your code, run it, and adhere to standards. Instead of relying on me to do it for you. |
|
Hi, I just spent a wonderful summer vacation and delayed this PR, I'm sorry for not being put as a draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.