Add password visibility toggle #15605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wish the browsers would do that natively, but... they don't. So let's see this |
ornicar
reviewed
Jun 26, 2024
ui/bits/css/_auth.scss
Outdated
| background-color: currentColor; | ||
| transform: rotate(45deg); | ||
| top: 50%; | ||
| left: 0; |
There was a problem hiding this comment.
sorry about that, I appreciate the handcrafted solution here, but as the person who would be maintaining it for years, I prefer a oneliner instead :)
such as /account/twofactor, /account/close, /account/passwd and more
|
Thanks for reviewing and updating my PR. I noticed the changes made the code quite different from my original. Is this common for Lichess PRs? I usually prefer iterating on changes based on feedback but understand if this approach is preferred. |
|
I often find that feedback as code is quicker and more precise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First contribution 🥳
Issue: #14321
Add ability to toggle password visibility by clicking an eye icon. This functionality is available from both the login and registration pages. Tested on Firefox and Safari. Screenshots are from Firefox.