remove site globals #15617
Merged
remove site globals #15617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
requested changes
Jun 28, 2024
ui/common/src/common.ts
Outdated
| if (prop && typeof prop === 'object') deepFreeze(prop); | ||
| } | ||
| Object.freeze(obj); | ||
| } |
There was a problem hiding this comment.
is this new? I can't find where it's used.
ui/common/src/common.ts
Outdated
| : str; | ||
|
|
||
| // does not compare complex objects or non-enumerable properties | ||
| export function enumerableEquivalence(a: any, b: any, enforceArrayOrder = true): boolean { |
There was a problem hiding this comment.
I can't find where this is used.
ui/common/src/dialog.ts
Outdated
| }) | ||
| ).returnValue === 'yes' | ||
| ); | ||
| } |
There was a problem hiding this comment.
What's wrong with the native browser alert and confirm?
Also it probably should be in a different PR
ui/common/css/component/_dialog.scss
Outdated
| justify-content: end; | ||
| gap: 2em; | ||
| } | ||
| } |
There was a problem hiding this comment.
ui/common/src/dialog.ts
Outdated
| htmlText?: string; // content, text will be used as-is | ||
| cash?: Cash; // content, overrides htmlText, will be cloned and any 'none' class removed | ||
| htmlUrl?: string; // content, overrides htmlText and cash, url will be xhr'd | ||
| append?: { node: HTMLElement; where?: string; how?: 'after' | 'before' | 'child' }[]; // default 'child' |
There was a problem hiding this comment.
this new append.how doesn't seem to be used anywhere. It still compiles after I remove it.
|
should be good now. the alert dialog stuff was moved to a separate pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove dialog from site, along with a few other junk functions. code splitting obviates manual bundler deduplication