You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should not be taking lightly as it will affect all API responses using this function.
To put it short, e.args is a Seq[Matchable]. Without these changes, toString() gets called which is causing this to output ArraySeq(30), where 30 is the element in the sequence. If the sequence contained more elements, such as 60, it would ouput ArraySeq(30, 60).
By doing mkString it will concatenate all elements of the sequence into a string. We might want to do mkString(", ") to comma-separate each element if there are more than one. Going back to my example of ArraySeq(30, 60), the output would look like Must be at least 30, 60 characters long. That output does not make sense in this context, but its worth thinking about for other usages.
I don't think it makes sense to concatenate the arguments into one string. Instead, all arguments should be passed to .txt.
Try something like e.args* or whatever the scala syntax for that is.
I don't think it makes sense to concatenate the arguments into one string. Instead, all arguments should be passed to .txt. Try something like e.args* or whatever the scala syntax for that is.
I have made the change to use vararg expansion with e.args*, and confirmed that it works as expected.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15761.
This change should not be taking lightly as it will affect all API responses using this function.
To put it short,
e.argsis aSeq[Matchable]. Without these changes,toString()gets called which is causing this to outputArraySeq(30), where30is the element in the sequence. If the sequence contained more elements, such as60, it would ouputArraySeq(30, 60).By doing
mkStringit will concatenate all elements of the sequence into a string. We might want to domkString(", ")to comma-separate each element if there are more than one. Going back to my example ofArraySeq(30, 60), the output would look likeMust be at least 30, 60 characters long. That output does not make sense in this context, but its worth thinking about for other usages.