Improve broadcast date filtering #16047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a bit of a weird solution but I can't find any better one. Thanks. |
|
Wouldn't a cleaner solution be to prioritise more the text score? Or set a minimum textScore before considering the date "searchDate" -> $doc(
"$add" -> $arr(
$doc("$ifNull" -> $arr("$syncedAt", "$createdAt")),
$doc("$multiply" -> $arr($doc("$add" -> $arr("$tier", -RelayTour.Tier.NORMAL)), 60 * day)),
$doc("$multiply" -> $arr($doc("$meta" -> "textScore"), 30 * day))
)
) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16040
The issue seems to be because of MongoDB's underlying text search whose tokenisation doesn't prioritise the year enough to filter out tournaments titled with a different year. Being totally new to Scala and Mongo, I don't know if this is the right solution and what performance implications it may have, but it's a suggestion if the ability for users to easily filter on a year appearing in the tournament name is sufficiently important. Tested with a broadcast titled "British Championships 2024" where "championship 2021" would match under production code, and not match after the proposed change.