Emojis in notes #16165
Merged
Emojis in notes #16165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And mods quote UGC in notes. For regular user-notes, it's not an issue to allow emojis, because they are private.
Seemed to be purposely introduced like that in bd244e5 so maybe a specific reason?
kraktus
commented
Oct 4, 2024
Comment on lines
-17
to
-19
| "markdown" -> cleanTextWithSymbols | ||
| .verifying(Constraints.minLength(0), Constraints.maxLength(1000_000)) | ||
| .into[Markdown], |
There was a problem hiding this comment.
making a pr for that since seemed to be purposely introduced like that in bd244e5 so maybe a specific reason?
There was a problem hiding this comment.
maybe cleanTextWithSymbols took no arguments back then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.