Skip to content

Conversation

@ShawkMusic
Copy link
Contributor

Multiple times have I found myself not noticing a bishop among a line of pawns because they are too visually similar. Making the cross white will make it more visually distinct from the pawns.

@ornicar ornicar merged commit 03f6b92 into lichess-org:master Oct 5, 2024
2 checks passed
@kraktus
Copy link
Member

kraktus commented Oct 8, 2024

The white color of the cross stands out too much
image

I don't know why we keep updating piece sets that have been fine for years for seemingly no value...

@BiscuitFiend2592
Copy link

BiscuitFiend2592 commented Oct 8, 2024

Several users of the piece set are upset with the recent decision:
https://lichess.org/forum/lichess-feedback/maestro-black-bishops

I am the OP of the thread. I would repeat here my point that the initial criticism of the piece set is strange: the Bishops are diamond-shaped while the pawns are rounded. More generally, I echo the previous comment's concern about "updating" (read: messing with) piece sets that have been fine for years.

@ShawkMusic
Copy link
Contributor Author

@kraktus @BiscuitFiend2592

Thanks for linking the thread.

I've tried darkening the cross here:

Before:
Image

After:
Image

Does that solve the issue? Is it dark enough now, should it be darker, or should I just revert the change entirely?

@will-reynolds-maths
Copy link

I think that change makes it dark enough that the contrast isn't distracting, but I also think the piece set still looks a lot less aesthetically pleasing than it did originally. My reason is that nothing else in the design of the Black pieces uses that colour. Personally, I maintain that the Bishops were visually distinct enough from the Pawns as they were originally.

I recognize that others, including yourself, might disagree, but it does appear that many people were using maestro just fine before this change. In other words, it might be the case that a bunch of people disagree with my opinion, but it is quite likely that a bunch of people agree with me; I don't know how easily it can be looked up how many users use each piece set, but absent that data I would have to guess that quite a lot of people have been using maestro for years before this change.

I don't really have any practical suggestions as to how to resolve that disagreement in opinion. Unless you can point to a bunch of other people complaining about this same issue with this same piece set, I have to stand by my position that it would be better not to try to fix something that wasn't previously considered broken.

(Since as far as I know we're both just random lichess users, and it feels weird for this extremely low-stakes conversation to determine very visible changes to a site with millions of users, I would certainly be keen to hear from others about this, but I suspect not many will be so motivated by this issue that they create a GitHub account like I did.)

@ShawkMusic
Copy link
Contributor Author

ShawkMusic commented Oct 9, 2024

Yeah, that's fair. I'll revert the PR.

I still personally prefer the white crosses for practicality purposes, but if enough people want it to stay as it is, I can just use another piece set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants