move confirm with speech synthesis #16398
Conversation
| import { throttle } from 'common/timing'; | ||
| import { defined, charToRole } from 'common'; | ||
| import { defined } from 'common'; | ||
| import { speakable } from 'chess/sanWriter'; |
There was a problem hiding this comment.
doesn't that make all pages depend on chessops?
There was a problem hiding this comment.
it shouldn't, because it's not grabbing from the 'chess' barrel like it was before. sanWriter only imports types from chessops.
but it's always possible esbuild has decided to bundle them together (unlikely). i will check
There was a problem hiding this comment.
ok, chessops is not loaded on site (sanWriter is clean).
i did discover it is still loaded by round/ctrl courtesy of keyboardMove dependency - that could be fixed by separating keyboardMove's load stub from initModule. having them in the same bundle defeats the purpose.
on the other hand - meh, it's 37k and with cache disabled, we are only sending around 230 kb (compressed) over the wire total with rounds - and that includes i18n, fonts, and piece css,
There was a problem hiding this comment.
it was only one function bringing it into chess barrel. removed that and it's no longer fetched in rounds.
now it's only loaded by analysis, puzzles, insights, learn, nvui, storm, racer, keyboardMove, voice, editor, chart, and dgt.
…opied over via sync
…d warning to grammars
speak SAN followed by "confirm?" when both are enabled