Skip to content

Automatic orientation for puzzles in studies #16339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Automatic orientation for puzzles in studies #16339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/study/src/main/ChapterMaker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ final private class ChapterMaker(
case Orientation.Fixed(color) => color
case _ if isMe(tags.names.white) => Color.white
case _ if isMe(tags.names.black) => Color.black
// If it is a concealed chapter (puzzles from a coach/book/course), start from side which moves first
case _ if data.isConceal && !data.fen.isDefined => root.color
// if an outcome is known, then it's a finished game, which we show from white perspective by convention
case _ if tags.outcome.isDefined => Color.white
// in gamebooks (interactive chapter), we guess the orientation based on the last node
Expand Down