In the editor tab for a new study chapter, make the starting position match up with the variant #16481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he user has already edited and then switched the variant mode.
…rl.editor`, rather than the FEN.
ornicar
reviewed
Nov 26, 2024
| const triggerChange = () => | ||
| ctrl.editor | ||
| ? selectEl.dispatchEvent(new Event('change')) | ||
| : setTimeout(triggerChange, 1); |
There was a problem hiding this comment.
hmmm that doesn't look very good. Could there be a better way?
|
The new code is a bit of a hack, its purpose is not obvious. I'll argue that it adds too much complexity for the relatively rare use case that it covers. Can the editor be instantiated with the correct rules right away, instead? |
|
@ornicar Updated to set the rules directly after the editor is made, without needing the insert hack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pressing the 'starting position' button will always give the standard starting position in the editor, regardless of the variant selected. E.g.:
This PR makes it so that the rules are updated when a new variant is selected. This is useful when then pressing the 'starting position' button for racing kings, horde, and antichess (no castling rights).