Skip to content

express cloud eval capability with engine property #16497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024
Merged

express cloud eval capability with engine property #16497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b42c98b
express cloud eval capability with engine property
schlawg Nov 27, 2024
9116500
dont allow fsf 14 hce in cloud eval
schlawg Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ui/ceval/src/ctrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,7 @@ export default class CevalCtrl {
}

get isCacheable(): boolean {
//>=sf16 or fsf14+nnue
return (
this.engines.active?.tech === 'NNUE' && this.engines.active.requires.includes('dynamicImportFromWorker')
);
return !!this.engines.active?.cloudEval;
}

get showingCloud(): boolean {
Expand Down
3 changes: 3 additions & 0 deletions ui/ceval/src/engines/engines.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export class Engines {
tech: 'NNUE',
requires: ['sharedMem', 'simd', 'dynamicImportFromWorker'],
variants: [key],
cloudEval: true,
assets: {
version: 'sfw006',
root: 'npm/lila-stockfish-web',
Expand Down Expand Up @@ -72,6 +73,7 @@ export class Engines {
tech: 'NNUE',
requires: ['sharedMem', 'simd', 'dynamicImportFromWorker'],
minMem: 1536,
cloudEval: true,
assets: {
version: 'sfw006',
root: 'npm/lila-stockfish-web',
Expand All @@ -88,6 +90,7 @@ export class Engines {
tech: 'NNUE',
requires: ['sharedMem', 'simd', 'dynamicImportFromWorker'],
minMem: 2560,
cloudEval: true,
assets: {
version: 'sfw006',
root: 'npm/lila-stockfish-web',
Expand Down
2 changes: 2 additions & 0 deletions ui/ceval/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export interface ExternalEngineInfoFromServer extends BaseEngineInfo {

export interface ExternalEngineInfo extends ExternalEngineInfoFromServer {
tech: 'EXTERNAL';
cloudEval?: false;
}

export interface BrowserEngineInfo extends BaseEngineInfo {
Expand All @@ -57,6 +58,7 @@ export interface BrowserEngineInfo extends BaseEngineInfo {
assets: { root?: string; js?: string; wasm?: string; version?: string; nnue?: string[] };
requires: Feature[];
obsoletedBy?: Feature;
cloudEval?: boolean;
}

export type EngineInfo = BrowserEngineInfo | ExternalEngineInfo;
Expand Down