Skip to content

fix: sound slider not working on safari #16405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2024
Merged

fix: sound slider not working on safari #16405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d012e5
vertical slider for old safari
seren5240 Nov 12, 2024
00e32db
use one regex exec
seren5240 Nov 12, 2024
cd1c7f4
Merge branch 'master' into safari-slider
schlawg Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ui/common/src/device.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ export const isMobile = (): boolean => isAndroid() || isIOS();

export const isAndroid = (): boolean => /Android/.test(navigator.userAgent);

export const getSafariMajorVersion = (): number | undefined => {
const regex = /^((?!chrome|android).)*Version\/(\d+).*Safari/i;
const result = regex.exec(navigator.userAgent);
return result ? parseInt(result[2]) : undefined;
};

export const isIOS = (constraint?: { below?: number; atLeast?: number }): boolean => {
let answer = ios();
if (!constraint || !answer) return answer;
Expand Down
9 changes: 9 additions & 0 deletions ui/dasher/src/dasher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { Redraw } from 'common/snabbdom';
import { DasherCtrl } from './ctrl';
import { json as xhrJson } from 'common/xhr';
import { spinnerVdom, spinnerHtml } from 'common/spinner';
import { getSafariMajorVersion } from 'common/device';
import { init as initSnabbdom, type VNode, classModule, attributesModule, h } from 'snabbdom';

const patch = initSnabbdom([classModule, attributesModule]);
Expand All @@ -22,6 +23,14 @@ export default async function initModule(): Promise<DasherCtrl> {
vnode || element,
h('div#dasher_app.dropdown', ctrl?.render() ?? h('div.initiating', spinnerVdom())),
);

const safari = getSafariMajorVersion();
if (safari && safari < 18) {
const el = document?.querySelector("#dasher_app .sound input[type='range']");
if (el) {
(el as HTMLElement).style.appearance = 'slider-vertical';
}
}
};

redraw();
Expand Down