swap out paused video player for image #16589
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schlawg
commented
Dec 14, 2024
- recover cross site isolation when no stream is playing
- phones, tablets can use multithreaded stockfish when there's a pinned stream
- chrome gets advanced stockfish while both youtube AND twitch embeds are playing!
- i predict demands for custom pinned streamer images next.
schlawg
commented
Dec 14, 2024
| text-align: center; | ||
| line-height: normal; | ||
| opacity: 0; | ||
| color: #222e; |
There was a problem hiding this comment.
colors for the text bubble are given here and for the play button, towards the bottom of videoPlayer.ts. i consider these colors meet the criteria of "visible" for this PR and didn't spend time trying to fit in with the themes or even the background image (which is also possible). but they'll need some tweaks i reckon.
87c7266 to
369a67e
Compare
c847500 to
1bacd67
Compare
|
thumbs up from serg is enough for me |
|
Not so fast. AAArmstark wants to put together something in an image editor. so this is going back to draft mode until we can have a look at that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.