Chart icon positions on mobile phones #16533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2cce1f to
a61bb1a
Compare
ornicar
requested changes
Dec 7, 2024
… font size vs the chart dimensions.
ornicar
reviewed
Dec 8, 2024
|
the original sin was subjecting ourselves to font rendering concerns (baseline issues, all that) when drawing icons. ideally we want to say "center this geegaw in this div and expand to fill available space", or "render this geegaw at XxY on this canvas" and it should be the same on every browser. short of that, pushing things around to lined them up correctly as this PR does is the best we can hope for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16400. Fixes the issue by increasing the down-left shift for chart icons on mobile phones. Note: I've tested this on my iphone, but not on others like android. So if someone could test it that would be appreciated.
The following screenshots are for a 1500 player making a 7 0 challenge (also tested a number of other ratings and TCs):
Before:
After:
