- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.5k
 
Clearer advice-summary #16649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearer advice-summary #16649
Conversation
| 
           There has been a issue logged on the translation platform regarding the capitalisation: 
 
 Would you consider a different solution please @dav1312?  | 
    
| 
           My bad, I guess changing the source string is a better idea.  | 
    
| 
           Fair enough. If the solution will be changing some source strings, I would prefer to change the  So all the results being in lower case would provide some helpful distinction, without adding any padding for example. Let me know if you are preparing a pull request, otherwise I can do the PR myself.  | 
    
| 
           I wasn't aware the mobile app did it like that. In this case, should uppercase  Say if you are happy with it below and leave me to process it as I can do a trick with Crowdin's pre-translation feature, which will at least ping every translator to review the re-published strings.  | 
    
| 
           Sure, capitalize the strings (and revert my capitalize change)  | 
    
New key introduced; the existing key will be retained in /translation/source until Crowdin pre-translation is complete.
New keys introduced; the existing keys will be retained in /translation/source until Crowdin pre-translation is complete. The old keys should be deleted only after the pre-translations have been pulled into master.
| 
           I have created the pull request as promised in #16731. As a side note: 
 I tested the app with the offending language (Galician). This particular string renders as  Still - for assurance, and as a principle, we should avoid system-driven transformations when it comes to i18n. So pull #16731 should do good on the mobile side as well.  | 
    
          
 If its using css it might be using   | 
    
Capitalize errors so they match acpl and accuracy.
Separate players when there is no learn from your mistakes button.
Apply a bold style to player names to make them stand out.
Remove margin 0 when the screen is small.